[
https://issues.apache.org/jira/browse/SOLR-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050869#comment-16050869
]
ASF subversion and git services commented on SOLR-10834:
--------------------------------------------------------
Commit 625b1cba8be77cca061c72420050aa0c766aab39 in lucene-solr's branch
refs/heads/branch_6x from Chris Hostetter
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=625b1cb ]
SOLR-10834: Fixed tests and test configs to stop using numeric uniqueKey fields
Squashed commit of the following (from jira/SOLR-10834 branch):
commit 8f1043840f38533864b2c713daf066b6c3509147
commit 7b95773bd524cd86aaccc56cc33a003a9aff2004
commit b26bf9d60e2b94e0cdc365d1e2c0a37c33e24198
commit df11992106f8c338503b6e3e9a27ba6ddcfa2953
commit fcf98132410ed247e451bb449a8337a09bd857ce
commit 05e8e226de359a6d7bc99219eaec161a32268f17
commit 6dce948294351560948a32b64679b1879657af79
commit 53f97845caaa8adc25862e4017b94f3091063552
commit d5bfb5f57016341fbeaf73b5e4c9ed10dc3816d0
commit d333f7b1eee10893a81532ac2f5a77a46716d90b
commit 15983ceec4702dc8c7562250d59cd8231c67d46a
commit e18e2e771fb4678cb911a62bbc7c74a873466bf0
commit 134e210bdf601600a9d90dd0720a35cb122896b0
commit ec03260265f8a3bbdfd7f9b015de16a4950a05eb
commit 5d430057ed335801a524e1e7666061075ab6d859
commit 1625df3d21b8fa27815d7a7b89a55fc338eeb23b
(cherry picked from commit f1e2be64519a9ec815785b59e6187c3e99f7d998)
Conflicts:
solr/core/src/test/org/apache/solr/cloud/FullThrottleStoppableIndexingThread.java
solr/core/src/test/org/apache/solr/cloud/SegmentTerminateEarlyTestState.java
solr/core/src/test/org/apache/solr/cloud/autoscaling/AutoScalingHandlerTest.java
solr/core/src/test/org/apache/solr/core/MockInfoBean.java
solr/core/src/test/org/apache/solr/core/TestJmxIntegration.java
solr/core/src/test/org/apache/solr/handler/admin/MBeansHandlerTest.java
solr/core/src/test/org/apache/solr/handler/component/QueryElevationComponentTest.java
solr/core/src/test/org/apache/solr/schema/CopyFieldTest.java
solr/core/src/test/org/apache/solr/search/function/SortByFunctionTest.java
solr/core/src/test/org/apache/solr/search/mlt/SimpleMLTQParserTest.java
solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java
> test configs should be changed to stop using numeric based uniqueKey field
> --------------------------------------------------------------------------
>
> Key: SOLR-10834
> URL: https://issues.apache.org/jira/browse/SOLR-10834
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
>
> Apparently, once upon a time, as a way to prove that it worked and there were
> no hard coded "String" assumptions, some the {{schema.xml}} used by tests was
> written such that the uniqueKey field was definied as an "int".
> This has now snowballed such that there are at least 40 test schema files
> (just in solr/core!) that define the uniqueKey field using a Trie field
> (mostly TrieInt, but at least 2 TrieFloats!) despite the fact that at no
> point have we ever recommended/encouraged people to use anything other then
> StrField for their uniqueKey.
> that's nearly 1/3 of all the test schemas that we have -- which IIRC (from
> some early experiments in SOLR-10807) are used in more then half the
> solr/core tests.
> If we want to be able to deprecate/remove Trie fields in favor of point
> fields, we're really going to update all of these test schemas to use a
> StrField (we can't use PointFields as the uniqueKey due to the issues noted
> in SOLR-10829) ... but AFAICT that's going to require a non trivial amount of
> work due to many of these tests making explicit/implicit assumptions about
> the datatype of the uniqueKey field (ex: sorting by id, range queries on ids,
> casting stored field values returned by solrj, xpath expressions, etc...)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
