[
https://issues.apache.org/jira/browse/LUCENE-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051684#comment-16051684
]
Adrien Grand commented on LUCENE-7877:
--------------------------------------
It looks good to me but I'm not as familiar with the TokenStream API is
[~thetaphi] is.
- should we only add OffsetAttribute to the concatenated stream if it can be
found on the sources?
- should we use a single {{copyTo}} call instead of
{{captureState}}+{{restoreState}} on every token?
- could you use IOUtils.close to close all sources at once so that we keep
trying to close other sources if any of them throws an exception upon closing?
- the patch does not remove PrefixAwareTokenFilter, did you just forget to git
rm it?
> Replace PrefixAwareTokenStream
> ------------------------------
>
> Key: LUCENE-7877
> URL: https://issues.apache.org/jira/browse/LUCENE-7877
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Attachments: LUCENE-7877.patch
>
>
> PrefixAwareTokenStream/PrefixAndSuffixAwareTokenStream use the deprecated and
> broken Token class, which means they will not work with custom attributes.
> We should fix/replace them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
