[ https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059746#comment-16059746 ]
David Smiley commented on LUCENE-7737: -------------------------------------- * in LatLonPointSpatialField did you purposefully remove {{@SuppressWarnings("unchecked")}} for the cast? If so why? If not please put back. * perhaps move GeoDistValueSourceParser.WrappedDoubleValueSource to ValueSource.toDoubleValueSource (inverse of .asDoubleValueSource) ? * SerializedDVStrategy.ShapeDocValueSource: You can now simply remove the BytesRefBuilder here. I recall I once had this to avoid re-fetching the docValues.binaryValue() when callers sometimes call exists() but that's no longer pertinent with the move to an iteration based API. * Maybe define ShapeValues as inner class of ShapeValueSource? * Why the changes to geo3d test stuff? * Why the change to DistanceStrategyTest? Thanks again for all your work on this issue! > Remove spatial-extras dependency on queries > ------------------------------------------- > > Key: LUCENE-7737 > URL: https://issues.apache.org/jira/browse/LUCENE-7737 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras > Reporter: Alan Woodward > Priority: Minor > Fix For: master (7.0) > > Attachments: LUCENE-7737.patch, LUCENE-7737.patch > > > The spatial-extras module uses ValueSources for a number of different > purposes, requiring a dependency on the queries module. I'd like to try > using core-only interfaces here instead, allowing us to remove the dependency -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org