[ https://issues.apache.org/jira/browse/SOLR-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060954#comment-16060954 ]
ASF subversion and git services commented on SOLR-10502: -------------------------------------------------------- Commit a6f4f2dd9ce33a0aa3597e73a5ced0b96302c847 in lucene-solr's branch refs/heads/master from [~steve_rowe] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a6f4f2d ] SOLR-10503,SOLR-10502: Deprecate CurrencyField in favor of new CurrencyFieldType, which works with point fields and provides control over dynamic fields used for the raw amount and currency code sub-fields. > CurrencyField should support/default to docvalues for underlying polyfields > --------------------------------------------------------------------------- > > Key: SOLR-10502 > URL: https://issues.apache.org/jira/browse/SOLR-10502 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > > Noticed while working on SOLR-10472, This is currently in {{CurrencyField}} > ... > {code} > private void createDynamicCurrencyField(String suffix, FieldType type) { > String name = "*" + POLY_FIELD_SEPARATOR + suffix; > Map<String, String> props = new HashMap<>(); > props.put("indexed", "true"); > props.put("stored", "false"); > props.put("multiValued", "false"); > props.put("omitNorms", "true"); > int p = SchemaField.calcProps(name, type, props); > schema.registerDynamicFields(SchemaField.create(name, type, p, null)); > } > // ... > @Override > public void inform(IndexSchema schema) { > this.schema = schema; > createDynamicCurrencyField(FIELD_SUFFIX_CURRENCY, fieldTypeCurrency); > createDynamicCurrencyField(FIELD_SUFFIX_AMOUNT_RAW, fieldTypeAmountRaw); > } > {code} > ...this code should probably be changed to use docValues by default -- or at > the very least use the indexed/docValues options from the original (user > configured) {{CurrencyField}} when creating the underlying poly-fields. > (although in this case we'll want to be careful to ensure that if it's > {{docValues=true}} we should only end up with 2 sets of docValues -- > suffix_raw & suffix_currency -- and not 3, including the original) -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org