[ 
https://issues.apache.org/jira/browse/SOLR-10907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063073#comment-16063073
 ] 

David Smiley commented on SOLR-10907:
-------------------------------------

This was not at all a location that could use try-with-resources.  The 
Closeable thing wasn't closed before and _nor should it be_.  Here a 
UninvertedReader constructed which is a is a FilteredReader; here we create it 
with Solr's SlowCompositeReaderAdapter.  We don't want to close _that_.  

> fix Resource Leak warning in ExpandComponent
> --------------------------------------------
>
>                 Key: SOLR-10907
>                 URL: https://issues.apache.org/jira/browse/SOLR-10907
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: clients - java
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-10907.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to