[ https://issues.apache.org/jira/browse/LUCENE-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064353#comment-16064353 ]
Mikhail Khludnev edited comment on LUCENE-7871 at 6/27/17 7:21 AM: ------------------------------------------------------------------- [^LUCENE-7871.patch] * fixes {{TestBlockJoinSelector.java}} for case when SortedDV has no vals for kids. * extracts ToParentDocValues into hairish OO piece * introduces {{BlockJoinSelector.wrap()}} acepting childred as DISI, no usage yet, existing are deprecated. Is there any veto, request to hold on? or it's fine to push it forward? was (Author: mkhludnev): [~LUCENE-7871.patch] * fixes {{TestBlockJoinSelector.java}} for case when SortedDV has no vals for kids. * extracts ToParentDocValues into hairish OO piece * introduces {{BlockJoinSelector.wrap()}} acepting childred as DISI, no usage yet, existing are deprecated. Is there any veto, request to hold on? or it's fine to push it forward? > false positive match BlockJoinSelector[SortedDV] when child value is absent > ---------------------------------------------------------------------------- > > Key: LUCENE-7871 > URL: https://issues.apache.org/jira/browse/LUCENE-7871 > Project: Lucene - Core > Issue Type: Bug > Reporter: Mikhail Khludnev > Attachments: LUCENE-7871.patch, LUCENE-7871.patch, LUCENE-7871.patch, > LUCENE-7871.patch, LUCENE-7871.patch > > > * fix false positive match for SortedSetDV > * make {{children}} an iterator instead of bitset. > see [the > comment|https://issues.apache.org/jira/browse/LUCENE-7407?focusedCommentId=16042640&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042640] -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org