[ 
https://issues.apache.org/jira/browse/SOLR-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064813#comment-16064813
 ] 

Shalin Shekhar Mangar commented on SOLR-10272:
----------------------------------------------

I can see why a bogus _default configset for tests would have been useful 
during development to identify tests that were not specifying configset names 
already during collection creation and switch them to use "conf" or "conf1" 
configsets explicitly. But I don't see its usefulness once this exercise is 
complete.

Since our collection creation API now uses _default configset by default, our 
tests should also do the same if no explicit configset name is specified. The 
_default for tests should be identical to the ones that users will use. This 
ensures that if a functionality is tested using the _default configset, it will 
actually work in the hands of our users. If we need to duplicate _default in 
two places to achieve this, then we should add a test to assert that both are 
same. This only really affects new tests since I am assuming existing ones have 
been cut over to "conf" already.

> Use a default configset and make the configName parameter optional.
> -------------------------------------------------------------------
>
>                 Key: SOLR-10272
>                 URL: https://issues.apache.org/jira/browse/SOLR-10272
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Assignee: Ishan Chattopadhyaya
>            Priority: Blocker
>             Fix For: master (7.0)
>
>         Attachments: SOLR-10272.patch, SOLR-10272.patch.gz, 
> SOLR-10272.patch.gz, SOLR-10272.patch.gz
>
>
> This Jira's motivation is to improve the creating a collection experience 
> better for users.
> To create a collection we need to specify a configName that needs to be 
> present in ZK. When a new user is starting Solr why should he worry about 
> having to know about configsets before he can can create a collection.
> When you create a collection using "bin/solr create" the script uploads a 
> configset and references it. This is great. We should extend this idea to API 
> users as well.
> So here is the rough outline of what I think we can do here:
> 1. When you start solr , the bin script checks to see if 
> "/configs/_baseConfigSet" znode is present . If not it uploads the 
> "basic_configs". 
> We can discuss if its the "basic_configs" or something other default config 
> set. 
> Also we can discuss the name for "/_baseConfigSet". Moving on though
> 2. When a user creates a collection from the API  
> {{admin/collections?action=CREATE&name=gettingstarted}} here is what we do :
> Use https://cwiki.apache.org/confluence/display/solr/ConfigSets+API to copy 
> over the default config set to a configset with the name of the collection 
> specified.
> collection.configName can truly be an optional parameter. If its specified we 
> don't need to do this step.
> 3. Have the bin scripts use this and remove the logic built in there to do 
> the same thing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to