[
https://issues.apache.org/jira/browse/SOLR-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-6807:
-------------------------------
Attachment: SOLR_6807_test_files.patch
SOLR_6807_handleSelect_false.patch
I've divided this into two patches to make this easier to review. The
test_files patch only has changes to files underneath any test-files dir (104
files), and these are universally solrconfig files. The other
handleSelect_false patch is everything else (47 files). The core change is to
{{SolrConfig.java}} which chooses the default value for handleSelect based on
the luceneMatchVersion.
This took a long time because there were so many old tests (and some newer)
that referred to request handlers using obsolete mechanisms. I finally got
through all the tests though.
org.apache.solr.client.solrj.impl.CloudSolrClientTest#stateVersionParamTest
fails sometimes for me but this appears to be an ongoing issue and not related
to this change.
Ant precommit is nearly finished without issue..
Ping [~anshumg] as you're the RM.
> Make handleSelect=false by default
> ----------------------------------
>
> Key: SOLR-6807
> URL: https://issues.apache.org/jira/browse/SOLR-6807
> Project: Solr
> Issue Type: Task
> Affects Versions: 4.10.2
> Reporter: Alexandre Rafalovitch
> Assignee: David Smiley
> Priority: Minor
> Labels: solrconfig.xml
> Fix For: master (7.0)
>
> Attachments: SOLR_6807_handleSelect_false.patch,
> SOLR_6807_handleSelect_false.patch, SOLR_6807_test_files.patch
>
>
> In the solrconfig.xml, we have a long explanation on the legacy
> *<requestDispatcher handleSelect="false" >* section. Since we are cleaning up
> legacy stuff for version 5, is it safe now to flip handleSelect's default to
> be *false* and therefore remove both the attribute and the whole section
> explaining it?
> Then, a section in Reference Guide or even a blog post can explain what to do
> for the old clients that still need it. But it does not seem to be needed
> anymore for the new users. And possibly cause confusing now that we have
> implicit, explicit and overlay handlers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
