[
https://issues.apache.org/jira/browse/SOLR-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065592#comment-16065592
]
David Smiley edited comment on SOLR-6807 at 6/27/17 10:34 PM:
--------------------------------------------------------------
When I commit this, my tentative CHANGES.txt mods are:
{noformat}
Upgrading ...
* <requestDispatcher handleSelect="..."> now defaults to false when
luceneMatchVersion >= 7.0, thus ignoring "qt". Regardless, "qt" is still
used as a SolrJ special
parameter that specifies the request handler (tail URL path) to use. If
you have request handlers without a leading '/', you can set
handleSelect="true"
or better yet consider migrating.
Other changes ...
* Changed <requestDispatcher handleSelect="..."> to default to false,
thus ignoring "qt". Simplified configs to not refer to handleSelect or "qt".
Updated all configs and tests to assume this setting. Updated all configs
and tests to use SearchHandler instead of the old StandardRequestHandler.
{noformat}
I could very easily simply remove StandardRequestHandler in 7.0 since I've
already done the work of migrating almost all configs away from it in this
issue. It wasn't strictly required but I did since I was already updating
configs to use {{/select}} which is the same config line. I could reference
this separately in "Upgrading from ...". The last actual code reference I see
is in SolrInfoBeanTest. Opinions?
was (Author: dsmiley):
When I commit this, my tentative CHANGES.txt mods are:
{noformat}
Upgrading ...
* <requestDispatcher handleSelect="..."> now defaults to false when
luceneMatchVersion >= 7.0, thus ignoring "qt". Regardless, "qt" is still used
as a SolrJ special parameter that specifies the request handler (tail URL path)
to use. If you have request handlers without a leading '/', you can set
handleSelect="true" or better yet consider migrating.
Other changes ...
* Changed <requestDispatcher handleSelect="..."> to default to false, thus
ignoring "qt". Simplified configs to not refer to handleSelect or "qt". Updated
all configs and tests to assume this setting. Updated all configs and tests to
use SearchHandler instead of the old StandardRequestHandler.
{noformat}
I could very easily simply remove StandardRequestHandler in 7.0 since I've
already done the work of migrating almost all configs away from it in this
issue. It wasn't strictly required but I did since I was already updating
configs to use {{/select}} which is the same config line. I could reference
this separately in "Upgrading from ...". The last actual code reference I see
is in SolrInfoBeanTest. Opinions?
> Make handleSelect=false by default
> ----------------------------------
>
> Key: SOLR-6807
> URL: https://issues.apache.org/jira/browse/SOLR-6807
> Project: Solr
> Issue Type: Task
> Affects Versions: 4.10.2
> Reporter: Alexandre Rafalovitch
> Assignee: David Smiley
> Priority: Minor
> Labels: solrconfig.xml
> Fix For: master (7.0)
>
> Attachments: SOLR_6807_handleSelect_false.patch,
> SOLR_6807_handleSelect_false.patch, SOLR_6807_test_files.patch
>
>
> In the solrconfig.xml, we have a long explanation on the legacy
> *<requestDispatcher handleSelect="false" >* section. Since we are cleaning up
> legacy stuff for version 5, is it safe now to flip handleSelect's default to
> be *false* and therefore remove both the attribute and the whole section
> explaining it?
> Then, a section in Reference Guide or even a blog post can explain what to do
> for the old clients that still need it. But it does not seem to be needed
> anymore for the new users. And possibly cause confusing now that we have
> implicit, explicit and overlay handlers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
