[
https://issues.apache.org/jira/browse/SOLR-10826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066772#comment-16066772
]
Varun Thacker commented on SOLR-10826:
--------------------------------------
Hi Tim,
Patch looks good to me and {{CloudSolrClient#testAliasHandling}} seems like a
good place for the test.
bq. E.g. suppose you made a request with &collection=x,y where either or both
of x and y are not real collection names but valid aliases.
Can we add another collection ( the test case already creates a 3 node cluster
so creating another collection and indexing a couple of docs should be cheap )
and test this specific thing as well. Should be a few more asserts.
What do you think? I'd be more happy to have that test and get it committed soon
> CloudSolrClient using unsplit collection list when expanding aliases
> --------------------------------------------------------------------
>
> Key: SOLR-10826
> URL: https://issues.apache.org/jira/browse/SOLR-10826
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Affects Versions: 6.4, 6.5.1, 6.6
> Reporter: Tim Owen
> Assignee: Varun Thacker
> Attachments: SOLR-10826.patch, SOLR-10826.patch
>
>
> Some recent refactoring seems to have introduced a bug in SolrJ's
> CloudSolrClient, when it's expanding a collection list and resolving aliases,
> it's using the wrong local variable for the alias lookup. This leads to an
> exception because the value is not an alias.
> E.g. suppose you made a request with {{&collection=x,y}} where either or both
> of {{x}} and {{y}} are not real collection names but valid aliases. This will
> fail, incorrectly, because the lookup is using {{x,y}} as a potential alias
> name lookup.
> Patch to fix this attached, which was tested locally and fixed the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
