[
https://issues.apache.org/jira/browse/SOLR-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068534#comment-16068534
]
Shalin Shekhar Mangar commented on SOLR-10397:
----------------------------------------------
Thanks Dat. I looked at the autoscaling branch and reviewed the test mostly. A
few comments:
# The code which creates the set of coreNodeNames on the lost node isn't
correct because multiple cores can have the same coreNodeName if they belong to
different collections. Moreover, there is no guarantee that the node we shut
down actually had replicas from multiple collections. So we need a better logic
to assert that no replica belonging to a collection that has
autoAddReplicas=false is moved on nodeLost event.
# Why remove the implicitly created trigger in
AutoAddReplicasPlanActionTest.testSimple? I presume it is because you want to
explicitly create the AutoAddReplicasPlanAction which is fine but in that case,
a proper end-to-end integration test is also necessary.
I'd appreciate if [~noble.paul] can review the changes to Policy and relevant
test coverage.
> Port 'autoAddReplicas' feature to the policy rules framework and make it work
> with non-shared filesystems
> ---------------------------------------------------------------------------------------------------------
>
> Key: SOLR-10397
> URL: https://issues.apache.org/jira/browse/SOLR-10397
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Cao Manh Dat
> Labels: autoscaling
> Fix For: master (7.0)
>
> Attachments: SOLR-10397.1.patch, SOLR-10397.patch
>
>
> Currently 'autoAddReplicas=true' can be specified in the Collection Create
> API to automatically add replicas when a replica becomes unavailable. I
> propose to move this feature to the autoscaling cluster policy rules design.
> This will include the following:
> * Trigger support for ‘nodeLost’ event type
> * Modification of existing implementation of ‘autoAddReplicas’ to
> automatically create the appropriate ‘nodeLost’ trigger.
> * Any such auto-created trigger must be marked internally such that setting
> ‘autoAddReplicas=false’ via the Modify Collection API should delete or
> disable corresponding trigger.
> * Support for non-HDFS filesystems while retaining the optimization afforded
> by HDFS i.e. the replaced replica can point to the existing data dir of the
> old replica.
> * Deprecate/remove the feature of enabling/disabling ‘autoAddReplicas’ across
> the entire cluster using cluster properties in favor of using the
> suspend-trigger/resume-trigger APIs.
> This will retain backward compatibility for the most part and keep a common
> use-case easy to enable as well as make it available to more people (i.e.
> people who don't use HDFS).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
