Here's another one I found in web.xml <!-- Remove in Solr 5.0 --> <!-- This sends SC_MOVED_PERMANENTLY (301) for resources that changed in 4.0 --> <servlet> <servlet-name>RedirectOldAdminUI</servlet-name> <servlet-class>org.apache.solr.servlet.RedirectServlet</servlet-class> <init-param> <param-name>destination</param-name> <param-value>${context}/#/</param-value> </init-param> </servlet>
On Tue, Jun 27, 2017 at 8:11 AM, Erick Erickson <erickerick...@gmail.com> wrote: > Hmmm, I probably put the one in SolrResourceLoader.java:108 but it > sure looks bogus. The name "coreProperties" fooled me into thinking it > was part of the solr.xml <cores> tag processing but apparently not. > I'll remove the comment as part of the current patch I'm working on. > > Thanks for finding! > > Erick > > On Tue, Jun 27, 2017 at 1:54 AM, Jan Høydahl <jan....@cominvent.com> > wrote: > > A quick grep for “Solr 7” and “remove in" gives > > > > ./core/src/java/org/apache/solr/core/SolrResourceLoader.java:108: > //TODO: Solr5. Remove this completely when you obsolete putting <core> tags > in solr.xml (See Solr-4196) > > ./core/src/java/org/apache/solr/cloud/OverseerCollectionMessageHandler.java:464: > //TODO should we not remove in the next release ? > > ./core/src/java/org/apache/solr/core/NodeConfig.java:309: // Remove > in Solr 7.0 > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:105: * > @deprecated Use the ctor that also takes printerNewline. This ctor will be > removed in Solr 7. > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:117: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:122: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:127: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:133: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:138: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:145: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:152: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:159: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:164: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:173: /** > @deprecated will be removed in Solr 7 */ > > ./core/src/java/org/apache/solr/internal/csv/CSVStrategy.java:186: * > @deprecated will be removed in Solr 7 > > > > > > Anyone remember writing those comments? Now is the time to nuke that > dead code :) > > > > -- > > Jan Høydahl, search solution architect > > Cominvent AS - www.cominvent.com > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > > For additional commands, e-mail: dev-h...@lucene.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > >