[
https://issues.apache.org/jira/browse/SOLR-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072978#comment-16072978
]
Anshum Gupta commented on SOLR-10456:
-------------------------------------
bq. I named it generically so that it could possibly be expanded to fit other
properties such as the RequestWriter and ResponseParser in the future.
sure, that sounds good.
bq. I though of having a "SolrClientBuilder" abstract class, which has
protected fields and the withFoo methods that are common across many of the
implementations to cut down on a lot of the duplication.
That was pretty much my thought, but it certainly belongs to a separate issue.
It's an implementation detail so we should be fine with that coming out later
too.
> timeout-related setters should be deprecated in favor of SolrClientBuilder
> methods
> ----------------------------------------------------------------------------------
>
> Key: SOLR-10456
> URL: https://issues.apache.org/jira/browse/SOLR-10456
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Assignee: Anshum Gupta
> Priority: Minor
> Fix For: 7.0
>
> Attachments: SOLR-10456.patch, SOLR-10456.patch, SOLR-10456.patch,
> SOLR-10456.patch
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each
> {{SolrClient}} can be deprecated, and their functionality moved over to the
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy"
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the
> {{setConnectionTimeout}} and {{setSoTimeout}} setters on all {{SolrClient}}
> implementations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
