[ https://issues.apache.org/jira/browse/SOLR-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anshum Gupta updated SOLR-11004: -------------------------------- Affects Version/s: (was: master (8.0)) > Consolidate SolrClient Builder code in abstract parent class > ------------------------------------------------------------ > > Key: SOLR-11004 > URL: https://issues.apache.org/jira/browse/SOLR-11004 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ > Reporter: Jason Gerlowski > Assignee: Anshum Gupta > Priority: Minor > Fix For: 7.0, master (8.0) > > Attachments: SOLR-11004.patch, SOLR-11004.patch > > > As [~anshumg] pointed out in SOLR-10456, the Builder code for each SolrClient > has a lot of duplication in it. > For example, each SolrClient allows configuration of the connection timeout: > all 4 builders have a field to store this value, all 4 builders have a > {{withConnectionTimeout}} method to set this value, and all 4 builders have > very similar Javadocs documenting what this value can be used for. > The same can be said for 5 or 6 other properties common to most/all > SolrClient's. > This duplication could be removed by creating an abstract SolrClientBuilder > class, which each of the specific Builders extend. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org