[ 
https://issues.apache.org/jira/browse/SOLR-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078861#comment-16078861
 ] 

Varun Thacker commented on SOLR-11003:
--------------------------------------

Hi Amrit,

Patch is looking good!

Let's add some code comments in CDCRTransactionLog and CDCRReplicator.

For example, this change in CDCRTransactionLog is confusing till you look at 
CDCRReplicator#isTargetCluster 
{code}
        if 
(cmd.getReq().getParamString().contains(CdcrUpdateProcessor.CDCR_UPDATE)) {
          codec.writeTag(JavaBinCodec.ARR, 6);
        } else {
          codec.writeTag(JavaBinCodec.ARR, 5);
        }
{code}


The test has adds, deleteByid and deleteByQuery.  Can we also test for in place 
updates ( I didn't see a anything triggering that code path ) 
Also it wouldn't hurt to add atomic updates to the test.

> Enabling bi-directional CDCR active-active clusters
> ---------------------------------------------------
>
>                 Key: SOLR-11003
>                 URL: https://issues.apache.org/jira/browse/SOLR-11003
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: CDCR
>            Reporter: Amrit Sarkar
>            Assignee: Varun Thacker
>         Attachments: sample-configs.zip, SOLR-11003.patch
>
>
> The latest version of Solr CDCR across collections / clusters is in 
> active-passive format, where we can index into source collection and the 
> updates gets forwarded to the passive one and vice-versa is not supported.
> https://lucene.apache.org/solr/guide/6_6/cross-data-center-replication-cdcr.html
> https://issues.apache.org/jira/browse/SOLR-6273
> We are try to get a  design ready to index in both collections and the 
> updates gets reflected across the collections in real-time. 
> ClusterACollectionA => ClusterBCollectionB | ClusterBCollectionB => 
> ClusterACollectionA.
> The best use-case would be to we keep indexing in ClusterACollectionA which 
> forwards the updates to ClusterBCollectionB. If ClusterACollectionA gets 
> down, we point the indexer and searcher application to ClusterBCollectionB. 
> Once ClusterACollectionA is up, depending on updates count, they will be 
> bootstrapped or forwarded to ClusterACollectionA from ClusterBCollectionB and 
> keep indexing on the ClusterBCollectionB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to