[ 
https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Isabelle Giguere updated SOLR-7913:
-----------------------------------
    Attachment: SOLR-7913.patch

Patch SOLR-7913, updated to Solr 6.6.0.

Adding unit tests.

First 2 unit tests in CloudMLTQParserTest look scary, because the results are 
so different, between the MLT query with id, and the "equivalent" query with 
stream.body.

I tested locally, to compare results with Solr 5.4.1 + patch (in our product, 
currently) and Solr 6.6.0 + patch, and there is no important difference, when 
comparing results of MLT with stream.body between Solr versions.  That's the 
important thing for us... Your opinion may differ.

I'm actually more puzzled that SimpleMLTQParser retrieves exactly the same 
results with id, and with stream.body!  How does it know what document to 
remove?

One note about that weird "TODO" in RequestUtils : why not let the handler 
propagate the content-type it expects, if any, instead of trying to guess in 
the utility method?  I'm not sure exactly where/how to do that, and how much 
impact it would have.

> Add stream.body support to MLT QParser
> --------------------------------------
>
>                 Key: SOLR-7913
>                 URL: https://issues.apache.org/jira/browse/SOLR-7913
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Anshum Gupta
>         Attachments: SOLR-7913.patch, SOLR-7913.patch, SOLR-7913.patch
>
>
> Continuing from 
> https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011.
> It'd be good to have stream.body be supported by the mlt qparser.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to