[
https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096408#comment-16096408
]
Trey Grainger commented on SOLR-10494:
--------------------------------------
Hi [~janhoy].
I picked it up a few times, but was developing against master and kept running
into stability issues with other tests every time I pulled. I finally switched
over to just developing on the 7.x branch instead to prevent those issues. I
have an updated patch which fixes some (now) merge conflicts with the default
configset changes, and all tests appear to be passing except the
TestHierarchicalDocBuilder.testThreeLevelHierarchy one. I still haven't been
able to dig deep enough to understand what is effecting that one.
I DO know that the issues is related to indention. If I go into the test and
override it to "indent=off" then it succeeds, but I have no idea why indention
being on is causing the failure. Also, doing that in the test is probably just
masking another underlying problem, which may not even be test related, so I
really need to understand exactly where things are breaking down to know if
it's a test problem or an actual functionality problem somewhere.
At any rate, I'll post my updated patch here shortly. I'm a little tight on
time this next week, so hopefully I can enlist someone else to assist on my end
later today, as well.
> Switch Solr's Default Response Type from XML to JSON
> ----------------------------------------------------
>
> Key: SOLR-10494
> URL: https://issues.apache.org/jira/browse/SOLR-10494
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
> Affects Versions: 7.0
> Reporter: Trey Grainger
> Priority: Blocker
> Fix For: 7.0
>
> Attachments: SOLR-10494, SOLR-10494, SOLR-10494.patch,
> SOLR-10494-withdocs.patch, SOLR-10494-withdocs.patch
>
>
> Solr's default response format is still XML, despite the fact that Solr has
> supported the JSON response format for over a decade, developer mindshare has
> clearly shifted toward JSON over the years, and most modern/competing systems
> also use JSON format now by default.
> In fact, Solr's admin UI even explicitly adds wt=json to the request (by
> default in the UI) to override the default of wt=xml, so Solr's Admin UI
> effectively has a different default than the API.
> We have now introduced things like the JSON faceting API, and the new more
> modern /V2 apis assume JSON for the areas of Solr they cover, so clearly
> we're moving in the direction of JSON anyway.
> I'd like propose that we switch the default response writer to JSON (wt=json)
> instead of XML for Solr 7.0, as this seems to me like the right direction and
> a good time to make this change with the next major version.
> Based upon feedback from the Lucene Dev's mailing list, we want to:
> 1) Change the default response writer type to "wt=json" and also change to
> "indent=on" by default
> 2) Make no changes on the update handler side; it already works as desired
> (it returns the response in the same content-type as the request unless the
> "wt" is passed in explicitly).
> 3) Keep the /query request handler around since people have already used it
> for years to do JSON queries
> 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks
> on how to change (back) the response format.
> The default format change, plus the addition of "indent=on" are back compat
> changes, so we need to make sure we doc those clearly in the CHANGES.txt.
> There will also need to be significant adjustments to the Solr Ref Guide,
> Tutorial, etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
