[ 
https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101670#comment-16101670
 ] 

Ignacio Vera edited comment on LUCENE-7906 at 7/26/17 1:37 PM:
---------------------------------------------------------------

I corrected the code above.

I found the issue, it is in line 496 of GeoComplexPolygon:

if (right != null && minValue >= low && right.traverse(edgeIterator, minValue, 
maxValue) == false) {

|It seems that the condition  minValue >= low prevents to look for necessary 
planes. If a change the condition to maxValue >= low my test run smooth but I 
don't know if it is correct. What it is sure is that the condition is not 
right. Any ideas?




was (Author: ivera):
I coorected the code above.

I found the issue, it is in line 496 of GeoComplexPolygon:

if (right != null && minValue >= low && right.traverse(edgeIterator, minValue, 
maxValue) == false) {

|It seems that the condition  minValue >= low prevents to look for necessary 
planes. If a change the condition to maxValue >= low my test run smooth but I 
don't know if is correct. What it is sure is that the conditin is not right. 
Any ideas?



> Spatial relationship between Geoshapes
> --------------------------------------
>
>                 Key: LUCENE-7906
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7906
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: LUCENE-7906.patch
>
>
> Hi,
> Working with geosahpes and trying to resolve spatial relationships between 
> them I came accross a big limitation when trying to solve the relationship 
> between two geopolygons. This object does not expose the internal structure. 
> In particular at some point, it is necessary to check if one polygon 
> intersects the edges of the other polygon which currently is not possible as 
> edges are not exposed.
> To be able to perform such operation it can be several options. The ones I 
> can think of are:
> 1) Expose the edges of the polygon ( and probably the notable points for the 
> edges) adding getters in the GeoPolygon interface. Easy to implement and 
> leave users the responsability of coding the spatial relationship.
> 2) Extends GeoPolygon interface to extends geoarea and leave the object make 
> the spatial relationship. 
> 3) Extends GeoShape  interface so all shapes can infer the spatial 
> relationship with other GeoShapes.
> I might be bias as my interest is in 2d Shapes in the unit sphere and there 
> might be some cases which what I propose cannot be implemented or are againts 
> the aim of the library.
> What do you think?
> Cheers,
> Ignacio



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to