[ https://issues.apache.org/jira/browse/SOLR-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102756#comment-16102756 ]
ASF subversion and git services commented on SOLR-10734: -------------------------------------------------------- Commit edff113e13f2a108d2f4177da3e88cf6f3402b23 in lucene-solr's branch refs/heads/master from [~noble.paul] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=edff113 ] SOLR-10734: AtomicUpdateProcessorFactoryTest was not truly multithreaded > Multithreaded test/support for AtomicURP broken > ----------------------------------------------- > > Key: SOLR-10734 > URL: https://issues.apache.org/jira/browse/SOLR-10734 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Ishan Chattopadhyaya > Attachments: log-snippet, Screen Shot 2017-05-31 at 4.50.23 PM.png, > SOLR-10734.patch > > > The multithreaded test doesn't actually start the threads, but only invokes > the run directly. The join afterwards doesn't do anything, hence. > {code} > diff --git > a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > > b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > index f3f833d..10b7770 100644 > --- > a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > +++ > b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends > SolrTestCaseJ4 { > } > } > }; > - t.run(); > + t.run(); // red flag, shouldn't this be t.start? > threads.add(t); > finalCount += index; //int_i > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org