[
https://issues.apache.org/jira/browse/SOLR-11155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated SOLR-11155:
------------------------------
Attachment: SOLR-11155.patch
bq. Hmm, digging into the code a big, this does seem like a legitimate error
(as opposed to an accidental bug).
I agree, thanks [~gerlowskija] for looking into it and for making a patch. I
realized that the problem also affects the DocumentAnalysisRequestHandler, and
that it would be fairly easy to implement support, so I've done that, rather
than going with your clean exception patch.
The attached patch adds points support for analysis requests, as well as tests
for FieldAnalysisRequestHandler and DocumentAnalysisRequestHandler.
I plan on committing once precommit and all Solr tests pass.
> /analysis/field and /analysis/document requests should support points fields
> ----------------------------------------------------------------------------
>
> Key: SOLR-11155
> URL: https://issues.apache.org/jira/browse/SOLR-11155
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Priority: Blocker
> Labels: numeric-tries-to-points
> Fix For: 7.0
>
> Attachments: SOLR-11155.patch, SOLR-11155.patch
>
>
> The following added to FieldAnalysisRequestHandlerTest currently fails:
> {code:java}
> @Test
> public void testIntPoint() throws Exception {
> FieldAnalysisRequest request = new FieldAnalysisRequest();
> request.addFieldType("pint");
> request.setFieldValue("5");
> handler.handleAnalysisRequest(request, h.getCore().getLatestSchema());
> }
> {code}
> as follows:
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test
> -Dtestcase=FieldAnalysisRequestHandlerTest -Dtests.method=testIntPoint
> -Dtests.seed=167CC259812871FB -Dtests.slow=true -Dtests.locale=fi-FI
> -Dtests.timezone=Asia/Hebron -Dtests.asserts=true
> -Dtests.file.encoding=US-ASCII
> [junit4] ERROR 0.01s | FieldAnalysisRequestHandlerTest.testIntPoint <<<
> [junit4] > Throwable #1: java.lang.UnsupportedOperationException: Can't
> generate internal string in PointField. use PointField.toInternalByteRef
> [junit4] > at
> __randomizedtesting.SeedInfo.seed([167CC259812871FB:6BF651CEF8FF5B04]:0)
> [junit4] > at
> org.apache.solr.schema.PointField.toInternal(PointField.java:187)
> [junit4] > at
> org.apache.solr.schema.FieldType$DefaultAnalyzer$1.incrementToken(FieldType.java:488)
> [junit4] > at
> org.apache.solr.handler.AnalysisRequestHandlerBase.analyzeTokenStream(AnalysisRequestHandlerBase.java:188)
> [junit4] > at
> org.apache.solr.handler.AnalysisRequestHandlerBase.analyzeValue(AnalysisRequestHandlerBase.java:102)
> [junit4] > at
> org.apache.solr.handler.FieldAnalysisRequestHandler.analyzeValues(FieldAnalysisRequestHandler.java:225)
> [junit4] > at
> org.apache.solr.handler.FieldAnalysisRequestHandler.handleAnalysisRequest(FieldAnalysisRequestHandler.java:186)
> [junit4] > at
> org.apache.solr.handler.FieldAnalysisRequestHandlerTest.testIntPoint(FieldAnalysisRequestHandlerTest.java:435)
> {noformat}
> If points fields aren't supported by the FieldAnalysisRequestHandler, then
> this should be directly stated in the error message, which should be a 4XX
> error rather than a 5XX error.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
