[ https://issues.apache.org/jira/browse/SOLR-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113293#comment-16113293 ]
Steve Rowe edited comment on SOLR-11023 at 8/3/17 6:55 PM: ----------------------------------------------------------- WIP patch, hopefully code complete, more testing needed (described by Hoss'ss nocommits in EnumFieldTest). Changes from Hoss'ss patch: Most nocommits are resolved. I renamed HuperDuperEnumField to EnumFieldType. I decided not to support uninversion in EnumFieldType (I couldn't figure out how to make it work), and also to require docValues, since I think it would be a trap to allow a situation where sorting isn't supported over a field that claims to support arbitrary sorting over the enum values. I've added a test to ensure that an exception is thrown when docvalues aren't enabled for an EnumFieldType field. was (Author: steve_rowe): WIP patch, hopefully code complete, more testing needed (described by Hoss'ss nocommits in EnumFieldTest). Changes from Hoss'ss patch: Most nocommits are resolved. I renamed HuperDuperEnumField to EnumFieldType. I decided not to support uninversion in EnumFieldType (I couldn't figure out how to make it work), and also to require docValues, since I think it would be a trap to allow a situation where sorting isn't supported over a field that claims to support arbitrary sorting over the enum values. I've added a test to throw an exception when docvalues aren't enabled for an EnumFieldType field. > Need SortedNumerics/Points version of EnumField > ----------------------------------------------- > > Key: SOLR-11023 > URL: https://issues.apache.org/jira/browse/SOLR-11023 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Steve Rowe > Priority: Blocker > Labels: numeric-tries-to-points > Fix For: 7.0 > > Attachments: SOLR-11023.patch, SOLR-11023.patch, SOLR-11023.patch > > > although it's not a subclass of TrieField, EnumField does use > "LegacyIntField" to index the int value associated with each of the enum > values, in addition to using SortedSetDocValuesField when {{docValues="true" > multivalued="true"}}. > I have no idea if Points would be better/worse then Terms for low cardinality > usecases like EnumField, but either way we should think about a new variant > of EnumField that doesn't depend on > LegacyIntField/LegacyNumericUtils.intToPrefixCoded and uses > SortedNumericDocValues. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org