You mean, remove the synchronization from the method and synchronize the whole thing on solrClients? How is that different?
> On Aug 10, 2017, at 12:48 PM, Erick Erickson <[email protected]> wrote: > > All the methods are synchronized, but they all operate on the > > private final Map<String, SolrClient> solrClients; > > member variable, including code like this: > > if (solrClients.containsKey(host)) { > client = (HttpSolrClient) solrClients.get(host); > }.... > > But the close method goes through the list closing all the entries in > solrClients. Seems like these ought to be synchronized blocks on > solrClients > > I have another place that needs updating too that I was investigating > when I saw this so I'll do them both at once if so (SOLR-11224) > > Erick > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
