[
https://issues.apache.org/jira/browse/SOLR-11054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123674#comment-16123674
]
Hoss Man commented on SOLR-11054:
---------------------------------
bq. We will replace AutoCommitTest.testMaxDocs() with this, so I think we
should assert that all docs from 0 -> softCommitMaxDocs must be searchable. The
rest looks very good to me.
[~caomanhdat]:
* your patch seems to have re-arranged SoftAutoCommitTest, moving the
testSoftAndHardCommitMaxDocs method i added in my early patch, making it hard
to compare your patch with mine to understand what changes you are suggesting
(ie: I applied my patch to one checkout, and your patch to a diff checkout, and
tried to diff them and the results showed that the method moved completely so
individual changes inside the method weren't obvious) ... so it's not clear to
me at first glance how you suggest we "assert that all docs from 0 ->
softCommitMaxDocs must be searchable"
* I think, in general, given how flakey and timing sensitive these autocommit
tests can be, that we should focus on making incremental small changes and
letting them soak on jenkins for several weeks -- hence the reason i created
individual sub-tasks (like this one) of SOLR-11053.
* If you think that there are (purely additive) additional
assertions/improvements that can/should be made to my proposed
SoftAutoCommitTest.testSoftAndHardCommitMaxDocs, i would suggest splitting your
additional assertions out into a new sub-task, and committing my earlier patch
first -- following up with your additions later -- to help isolate them if
there are any potential timing issues on jenkins machines (and make it simple
to review & comment on your suggested improvements in isolation)
* my chief concern being that the additional "all docs ... must be searchable"
assertions you are suggesting _may_ be just as problematic in
SoftAutoCommitTest as AutoCommitTest is currently. (as i mentioned: the
motivation of these individual subtasks for SOLR-11053 is to focus on small,
discrete, self contained, improvements -- and then in the parent issue
ultimately ask the question: "have we duplicated the (viable) code coverage to
the point we can remove AutoCommitTest?"
> Add SoftAutoCommitTest.testSoftAndHardCommitMaxDocs
> ---------------------------------------------------
>
> Key: SOLR-11054
> URL: https://issues.apache.org/jira/browse/SOLR-11054
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Attachments: SOLR-11054.patch, SOLR-11054.patch
>
>
> SoftAutoCommitTest should have a testSoftAndHardCommitMaxDocs that checks the
> maxDocs option for autocommit using the same monitor polling used by other
> existing SoftAutoCommitTest tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
