[ https://issues.apache.org/jira/browse/SOLR-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046072#comment-13046072 ]
Michael McCandless commented on SOLR-2564: ------------------------------------------ I think we should decouple the "should Lucene require Java 6" (which I expect to be an..... involved, discussion) from making progress here? My feeling is we should still commit this. The 16% slowdown is on a very synthetic case (MatchAllDocsQuery, sorting by reversed docID, grouping by random int field)... unless we also see unacceptable slowdowns in more realistic cases? Also, net/net the user should see a speedup, typically, since caching is enabled by default. We should still open an issue to cutover this code back to the pollLast once we can use Java 6 code. Another option is to allow the grouping module (separately from Lucene core) to use Java 6 code.... but even that could be "involved" :) Yonik, how do you create the index used for this test? Somehow you generate an int field w/ random 1000 unique values -- do you have a client-side script you use to create random docs in Solr? > Integrating grouping module into Solr 4.0 > ----------------------------------------- > > Key: SOLR-2564 > URL: https://issues.apache.org/jira/browse/SOLR-2564 > Project: Solr > Issue Type: Improvement > Reporter: Martijn van Groningen > Assignee: Martijn van Groningen > Fix For: 4.0 > > Attachments: LUCENE-2564.patch, SOLR-2564.patch, SOLR-2564.patch, > SOLR-2564.patch, SOLR-2564.patch, SOLR-2564.patch > > > Since work on grouping module is going well. I think it is time to wire this > up in Solr. > Besides the current grouping features Solr provides, Solr will then also > support second pass caching and total count based on groups. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org