[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135390#comment-16135390
]
Hoss Man commented on SOLR-8689:
--------------------------------
My thoughts in no particular order -- w/o having looked at /understood the
patch (i'm not familar with most windows batch file syntax)...
bq. BTW, I set this as blocker, as we cannot release Solr 7 at the same time
like Java 9 and it won't work.
I don't think "solr + windows + jdk9" is an important enough use case to
warrant holding up lucene/solr 7. We can release note that solr.cmd startup
script doesn't work in that permutation and focus on fixing later (if anyone is
really hardcore about using solr + windows + jdk9 they can probably work around
using the solr.cmd script)
bq. The GC_LOG_OPTS used as it was before the change on Java <= 8, but for Java
9 it is ignored. I have no better idea how to do this. IMHO, this is better
than not working at all! I added documentation for this.
My personal opinion is that it would be better to continue to support things as
best we can for existing solr users who may upgrade solr w/o caring about jdk9
at all -- ie: keep supporting/using GC_LOG_OPTS -- but in the special in the
case where they use jdk9 _and_ try to specify a value for the GC_LOG_OPTS ...
we should hard fail w/message that solr can't support GC_LOG_OPTS when using
jdk9.
I believe you said in your current patch you "ignored" GC_LOG_OPTS when using
jdk9? ... i think that's a mistake, as existing solr users who may have already
set GC_LOG_OPTS and then later upgrade to jdk9 will get confusing silently
different behavior. better to fail fast and be clear that they can't do that
(unless/until we find a better solution)
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
> ------------------------------------------------------------------------------------------------
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
> Affects Versions: 5.5, 6.0
> Environment: Windows 7
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-8689.patch, SOLR-8689.patch, SOLR-8689.patch,
> SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *****************************************************
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *****************************************************
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
