[
https://issues.apache.org/jira/browse/SOLR-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135628#comment-16135628
]
Uwe Schindler edited comment on SOLR-8689 at 8/21/17 7:20 PM:
--------------------------------------------------------------
Patch with [~hossman]'s suggestions. If somebody sets GC_LOG_OPTS on Java 9 it
bails out. I also updated documentation in the solr.in.cmd file.
I tested with:
- Java 8u144: Works as usual, GC_LOG_OPTS is respected if explicitely set
- Java 9b182: Works now by default; if you comment out the GC_LOG_OPTS it fails
early. BTW, in the UNIX scripts it would also fail if somebody updates Java 8
to Java 9, because the logging options are incompatible. So we are consistent
for users that have GC_LOG_OPTS configured and migrate.
- IBM J9 (Java 8): Works as before
- Java 7u90: Fails early
- Java 6: Fails early
I think we should really commit this and maybe later improve this. It looks
like I am the only active Solr committer that knows windows shell scripts a
bit. IMHO, maybe we should switch to PowerShell, really! PowerShell is now
installed on all supported Windows VMs, Windows 7 is out of service.
[~hossman]: Any complaints or do you trust me? The current state is much better
than before and the added code is trivial. IMHO, we should really not release
that without basic Java 9 support and some migration path. Java comes out on
Sept 21 (for sure, I already booked my tickets to the party in Munich).
was (Author: thetaphi):
Patch with [~hossman]'s suggestions. If somebody sets GC_LOG_OPTS on Java 9 it
bails out. I also updated documentation in the solr.in.cmd file.
I tested with:
- Java 8u144: Works as usual, GC_LOG_OPT is respected if explicitely set
- Java 9b182: Works now by default; if you comment out the GC_LOG_OPTS it fails
early. BTW, in the UNIX scripts it would also fail if somebody updates Java 8
to Java 9, because the logging options are incompatible. So we are consistent
for users that have GC_LOG_OPTS configured and migrate.
- IBM J9 (Java 8): Works as before
- Java 7u90: Fails early
- Java 6: Fails early
I think we should really commit this and maybe later improve this. It looks
like I am the only active Solr committer that knows windows shell scripts a
bit. IMHO, maybe we should switch to PowerShell, really! PowerShell is now
installed on all supported Windows VMs, Windows 7 is out of service.
[~hossman]: Any complaints or do you trust me? The current state is much better
than before and the added code is trivial. IMHO, we should really not release
that without basic Java 9 support and some migration path. Java comes out on
Sept 21 (for sure, I already booked my tickets to the party in Munich).
> bin/solr.cmd does not start with recent Verona builds of Java 9 because of
> version parsing issue
> ------------------------------------------------------------------------------------------------
>
> Key: SOLR-8689
> URL: https://issues.apache.org/jira/browse/SOLR-8689
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
> Affects Versions: 5.5, 6.0
> Environment: Windows 7
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Blocker
> Labels: Java9
> Fix For: 7.0, master (8.0), 7.1
>
> Attachments: SOLR-8689.patch, SOLR-8689.patch, SOLR-8689.patch,
> SOLR-8689.patch, SOLR-8689.patch
>
>
> At least on Windows, Solr 5.5 does not start with the shell script using a
> Verona-Java-9 JDK:
> {noformat}
> *****************************************************
> JAVA_HOME = C:\Program Files\Java\jdk-9
> java version "9-ea"
> Java(TM) SE Runtime Environment (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc)
> Java HotSpot(TM) 64-Bit Server VM (build
> 9-ea+105-2016-02-11-003336.javare.4433.nc, mixed mode)
> *****************************************************
> C:\Users\Uwe Schindler\Desktop\solr-5.5.0\bin>solr start
> ERROR: Java 1.7 or later is required to run Solr. Current Java version is:
> 9-ea
> {noformat}
> I don't know if this is better with Linux, but I assume the version parsing
> is broken (e.g., String#startsWith, interpret as floating point number,...)
> We should fix this before Java 9 gets released! The version numbering scheme
> changed completely: http://openjdk.java.net/jeps/223
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
