[
https://issues.apache.org/jira/browse/SOLR-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158059#comment-16158059
]
David Smiley commented on SOLR-8344:
------------------------------------
bq. No, It matter in case of "fl" contains a field which is stored only (let's
call it field1) and "rows" is small.
Which scenario is this in your benchmark above? Or some other benchmark you
allude to?
bq. Because we already have to pay for seek cost for reading field1 therefore
reading other fields from stored will be faster than reading from DV
I understand that but don't see what that has to do with the number of
documents.
In the event _every_ field in "fl" has docValues, stored, single valued: will
your patch use docValues data always? If not, why not? Maybe I should study
your patch further but I was a bit confused.
I would like to consider the relationship of this optimization on the document
cache, if not in this patch then perhaps in a follow-up. If in some request we
realize we can avoid accessing the stored document and instead do only with
docValues, we should avoid polluting the document cache as well, I think.
Maybe we will Consider the first phase of distributed search that only wants
the uniqueKey field.
In your patch, this: {{if (doc.containsKey(fieldName)) doc.remove(fieldName);}}
can be simplified to remove the needless condition
> Decide default when requested fields are both column and row stored.
> --------------------------------------------------------------------
>
> Key: SOLR-8344
> URL: https://issues.apache.org/jira/browse/SOLR-8344
> Project: Solr
> Issue Type: New Feature
> Reporter: Ishan Chattopadhyaya
> Attachments: SOLR-8344.patch
>
>
> This issue was discussed in the comments at SOLR-8220. Splitting it out to a
> separate issue so that we can have a focused discussion on whether/how to do
> this.
> If a given set of requested fields are all stored and have docValues (column
> stored), we can retrieve the values from either place. What should the
> default be?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
