Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/246#discussion_r137824698
  
    --- Diff: 
lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/RandomGeo3dShapeGenerator.java
 ---
    @@ -149,6 +150,26 @@ public PlanetModel randomPlanetModel() {
       }
     
       /**
    +   * Method that returns a random generated Planet model as string from 
the supported
    --- End diff --
    
    I don't think you need this method.  I think you are using it only for 
init(map) when the test using it could instead simply do randomBoolean() to 
directly set the planet model on the factory.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to