[ 
https://issues.apache.org/jira/browse/LUCENE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166303#comment-16166303
 ] 

Karl Wright commented on LUCENE-7970:
-------------------------------------

[~ivera], now I understand what you are trying to do.

There are several areas of concern:
(1) For extremely small circles, e.g. those with radii 
Vector.MINIMUM_ANGULAR_RESOLUTION, does this reliably work?
(2) For PlanetModel.SPHERE, can we "shortcut" to a faster implementation?  Or 
is the vincenti formula guaranteed to converge in one iteration in that case?  
I do not want to make it exorbitantly expensive to construct circles in 
PlanetModel.SPHERE.
(3) Paths also use circles.  The way those circles are constructed depends on 
whether the circles are intersection points, endpoints, or single circles. 
 The latter I think should behave exactly like GeoCircles, however that works 
out.  It may be valuable, therefore, to provide a Plane static builder method 
that can be used for both GeoStandardCircle and GeoStandardPath.



> Improve generation of circle plane 
> -----------------------------------
>
>                 Key: LUCENE-7970
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7970
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>         Attachments: LUCENE-7970.patch, LUCENE-7970-proposed.patch
>
>
> Hi [~Karl wright],
> How circles are currently build do not behave very well when the planet model 
> is not an sphere. when you are close to the border in WGS84 you might get 
> false positves or false negatives when checking if a point is WITHIN. I think 
> the reason is how the points to generate the circle plane are generated which 
> assumes a sphere.
> My proposal is the following:
> Add a new method to PlanetModel:  
> public GeoPoint pointOnBearing(GeoPoint from, double dist, double bearing);
> Which uses and algorithm that takes into account that the planet might not be 
> spherical. For example Vincenty's formulae 
> (https://en.wikipedia.org/wiki/Vincenty%27s_formulae).
> Use this method to generate the points for the circle plane. My experiments 
> shows that this approach removes false negatives in WGS84 meanwhile it works 
> nicely in the Sphere.
> Does it make sense?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to