[ https://issues.apache.org/jira/browse/LUCENE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048306#comment-13048306 ]
Michael McCandless commented on LUCENE-3193: -------------------------------------------- bq. This is mentioned in IndexWriter.rollback(). I don't think we should mention IW in TPC javadocs? Ahh, you're right. Good! bq. And TPCTool.execute has a NOTE about it, saying that for some TPC implementations, calling rollback() after commit() was successfully executed may be a no-op. Ahh, I missed that -- super. But: perhaps a different exception should be thrown if there is a problem in the commit() loop vs the prepareCommit() loop? This way caller can differentiate this case? > TwoPhaseCommit interface > ------------------------ > > Key: LUCENE-3193 > URL: https://issues.apache.org/jira/browse/LUCENE-3193 > Project: Lucene - Java > Issue Type: New Feature > Components: core/index > Reporter: Shai Erera > Assignee: Shai Erera > Fix For: 3.3, 4.0 > > Attachments: LUCENE-3193.patch > > > I would like to propose a TwoPhaseCommit interface which declares the methods > necessary to implement a 2-phase commit algorithm: > * prepareCommit() > * commit() > * rollback() > The prepare/commit ones have variants that take a (Map<String,String> > commitData) following the ones we have in IndexWriter. > In addition, a TwoPhaseCommitTool which implements a 2-phase commit amongst > several TPCs. > Having IndexWriter implement that interface will allow running the 2-phase > commit algorithm on multiple IWs or IW + any other object that implements the > interface. > We should mark the interface @lucene.internal so as to not block ourselves in > the future. This is pretty advanced stuff anyway. > Will post a patch soon -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org