[
https://issues.apache.org/jira/browse/LUCENE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195202#comment-16195202
]
Dawid Weiss commented on LUCENE-7983:
-------------------------------------
My bad, Steve. Thanks for pointing this out. I'll cherry pick tomorrow
(terribly late now, I'd probably screw up something).
> Make IndexReaderWarmer a functional interface
> ---------------------------------------------
>
> Key: LUCENE-7983
> URL: https://issues.apache.org/jira/browse/LUCENE-7983
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 7.1
>
>
> {{IndexReaderWarmer}} has a single method but is an abstract class with a
> confusing protected constructor. Can we make it a proper functional interface
> instead? This is marked as {{lucene.experimental}} API and while it would be
> a binary incompatibility, everything remains the same at the source level,
> even for existing implementations.
> {code}
> public static abstract class IndexReaderWarmer {
> /** Sole constructor. (For invocation by subclass
> * constructors, typically implicit.) */
> protected IndexReaderWarmer() {
> }
> /** Invoked on the {@link LeafReader} for the newly
> * merged segment, before that segment is made visible
> * to near-real-time readers. */
> public abstract void warm(LeafReader reader) throws IOException;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
