[ 
https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205181#comment-16205181
 ] 

Yonik Seeley commented on SOLR-11464:
-------------------------------------

bq.  I'm inclined to think Gus's simple refactoring is safe.

Even if it's shown there are no side-effects, Gus's other comment is the more 
important point IMO:
"Thought I would raise this so that folks can consider if something was lost 
here"

> Unused code in DistributedUpdateProcessor
> -----------------------------------------
>
>                 Key: SOLR-11464
>                 URL: https://issues.apache.org/jira/browse/SOLR-11464
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: master (8.0)
>            Reporter: Gus Heck
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: SOLR-11464.patch, unused.png
>
>
> While reading code I ran across a couple of suspicious unused 
> values/variables. Thought I would raise this so that folks can consider if 
> something was lost here, or if perhaps we can eliminate an unnecessary call 
> to zookeeper and tidy things up a bit. Screenshot and patch to eliminate 
> shortly...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to