[
https://issues.apache.org/jira/browse/SOLR-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-11464:
--------------------------------
Attachment: SOLR_11464_SOLR_11493_DistributedUrp.patch
I refactored this method further a little by reducing the indentation scope
(return early if zkEnabled), and limit the scope of the local {{List<Node>
nodes}} variable, and returning null where it would have been empty. In one
place used Collections.singletonList (callers never modify the result so we can
be immutable).
The tests passed with Gus's changes, and I'm running tests again now. If it
goes okay I'll commit it later.
(maybe one CHANGES.txt entry for 11464 and 11493 with comment "Minor
refactorings to DistributedUrp")
> Unused code in DistributedUpdateProcessor
> -----------------------------------------
>
> Key: SOLR-11464
> URL: https://issues.apache.org/jira/browse/SOLR-11464
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Affects Versions: master (8.0)
> Reporter: Gus Heck
> Assignee: David Smiley
> Priority: Minor
> Attachments: SOLR-11464.patch,
> SOLR_11464_SOLR_11493_DistributedUrp.patch, unused.png
>
>
> While reading code I ran across a couple of suspicious unused
> values/variables. Thought I would raise this so that folks can consider if
> something was lost here, or if perhaps we can eliminate an unnecessary call
> to zookeeper and tidy things up a bit. Screenshot and patch to eliminate
> shortly...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
