[
https://issues.apache.org/jira/browse/LUCENE-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216744#comment-16216744
]
Robert Muir commented on LUCENE-4100:
-------------------------------------
Can we add this comment to DisjunctionMaxScorer (and not just leave at
infinity):
{noformat}
// TODO: implement but be careful about floating-point errors.
{noformat}
Can we fix {{maxFreq}} calculation. Currently it is:
{noformat}
// TODO: store the max term freq?
if (ttf == -1) {
return Integer.MAX_VALUE;
} else {
return ttf - df + 1;
}
{noformat}
It should be:
{noformat}
// TODO: store the max term freq?
if (ttf == -1) {
// omitTFAP field, tf values are implicitly 1.
// note: it seems cleaner to check IndexOptions instead of looking at -1?
return 1;
} else {
return Math.min(Integer.MAX_VALUE, ttf - df + 1);
}
{noformat}
I only partially reviewed the patch... will look at it again tonight.
> Maxscore - Efficient Scoring
> ----------------------------
>
> Key: LUCENE-4100
> URL: https://issues.apache.org/jira/browse/LUCENE-4100
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs, core/query/scoring, core/search
> Affects Versions: 4.0-ALPHA
> Reporter: Stefan Pohl
> Labels: api-change, gsoc2014, patch, performance
> Fix For: 4.9, 6.0
>
> Attachments: LUCENE-4100.patch, LUCENE-4100.patch, LUCENE-4100.patch,
> contrib_maxscore.tgz, maxscore.patch
>
>
> At Berlin Buzzwords 2012, I will be presenting 'maxscore', an efficient
> algorithm first published in the IR domain in 1995 by H. Turtle & J. Flood,
> that I find deserves more attention among Lucene users (and developers).
> I implemented a proof of concept and did some performance measurements with
> example queries and lucenebench, the package of Mike McCandless, resulting in
> very significant speedups.
> This ticket is to get started the discussion on including the implementation
> into Lucene's codebase. Because the technique requires awareness about it
> from the Lucene user/developer, it seems best to become a contrib/module
> package so that it consciously can be chosen to be used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
