I wish that we only had one Solr mode as well.   We now have features that only 
work in SolrCloud mode, like the SQL handler….   For a very small 1000 document 
set up, I recently deployed it as a single node single shard no replica 
SolrCloud setup using embedded ZK, just to take advantage of the SQL handler!


> On Oct 27, 2017, at 5:32 PM, David Smiley <[email protected]> wrote:
> 
> DistributedUpdateProcessor (or what I call DURP for short) is very complex.  
> One aspect of the complexity is that it appears it tries to support SolrCloud 
> and classic Solr.  Do we still need it to support classic Solr?  When/why?  
> Forever?
> 
> If it needs to continue to operate in both modes, perhaps it could be 
> refactored into a base class and ZooKeeper subclass?  It's a code smell to 
> see the current code with "if (zkEnabled)" all over the place.
> 
> Any other ideas on making this code more maintainable?
> 
> ~ David
> -- 
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley 
> <http://linkedin.com/in/davidwsmiley> | Book: 
> http://www.solrenterprisesearchserver.com 
> <http://www.solrenterprisesearchserver.com/>

Reply via email to