[ https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Woodward updated LUCENE-8017: ---------------------------------- Attachment: LUCENE-8017.patch Updated patch, checking dvGen for DV queries and returning null if it's >= 0. bq. I agree we should not cache queries on the reader helper I can see cases where this would be useful - for example, a FunctionMatchQuery that uses the underlying score (reader-specific, because it uses global stats) could be cached in a long-running static index, but shouldn't be if anything is updated. So I think returning a specific Cache key rather that relying on just a boolean is the way to go here. > FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache > -------------------------------------------------------------------- > > Key: LUCENE-8017 > URL: https://issues.apache.org/jira/browse/LUCENE-8017 > Project: Lucene - Core > Issue Type: Bug > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Major > Attachments: LUCENE-8017.patch, LUCENE-8017.patch > > > The QueryCache assumes that queries will return the same set of documents > when run over the same segment, independent of all other segments held by the > parent IndexSearcher. However, both FunctionRangeQuery and > FunctionMatchQuery can select hits based on score, which depend on term > statistics over the whole index, and could therefore theoretically return > different result sets on a given segment. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org