[ https://issues.apache.org/jira/browse/LUCENE-8034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240759#comment-16240759 ]
Hari Menon commented on LUCENE-8034: ------------------------------------ [~rcmuir] That makes sense. I'll make that change. I'll actually remove the asserts, as all we need to verify that the hit was returned. So `checkHits()` should be enough. > SpanNotWeight returns wrong results due to integer overflow > ----------------------------------------------------------- > > Key: LUCENE-8034 > URL: https://issues.apache.org/jira/browse/LUCENE-8034 > Project: Lucene - Core > Issue Type: Bug > Components: core/query/scoring, core/search > Reporter: Hari Menon > Priority: Minor > Labels: newbie, patch > Attachments: LUCENE-8034.patch > > > In SpanNotQuery, there is an acceptance condition: > {code:java} > if (candidate.endPosition() + post <= excludeSpans.startPosition()) { > return AcceptStatus.YES; > } > {code} > This overflows in case `candidate.endPosition() + post > Integer.MAX_VALUE`. > I have a fix for this which I am working on. Basically I am flipping the add > to a subtract. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org