[
https://issues.apache.org/jira/browse/SOLR-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252802#comment-16252802
]
Gus Heck commented on SOLR-11487:
---------------------------------
All good points, many of them bits that didn't get cleaned up as related code
made them obsolete...
.
* *computeIfAbsent()* - used it in the constructor, elsewhere we don't want to
modify the map we are querying.
* *getZNodeVersion* - (/)
* *resolveAliases* - (/) That check was previously needed because a conversion
to map of list from map of comma separated string and the method doing the
conversion didn't like nulls. Now that that has gone away this can to.
* *Unmodifiable lists* - This thought had crossed my mind but I had a vague
worry that making them unmodifiable from the start might cause issues and
wanted to get the patch up so I didn't investigate, but I've found no support
for my worries. Lists are now unmodifiable from the start. I very much prefer
that they not be modifiable. If we are going to be immutable we should really
be immutable so as not to trick someone later, be they internal or external.
* *EMPTY_MAP* - (/) Yup, now we can go back to Collections.emptyMap() :)
* *cloneCollectionMetadataMap* - (/)
* *Array.equals()* - whoops, forgot to do that, thx.
* *sleep(1)* - that was my compromise such that the loop wasn't flaming hot,
just very toasty. I took it out and now stop the loop with a different message
if we have tried at least 5 times and failed vs timing out.
> Collection Alias metadata for time partitioned collections
> ----------------------------------------------------------
>
> Key: SOLR-11487
> URL: https://issues.apache.org/jira/browse/SOLR-11487
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: David Smiley
> Attachments: SOLR_11487.patch, SOLR_11487.patch, SOLR_11487.patch,
> SOLR_11487.patch, SOLR_11487.patch, SOLR_11487.patch, SOLR_11487.patch,
> SOLR_11487.patch
>
>
> SOLR-11299 outlines an approach to using a collection Alias to refer to a
> series of collections of a time series. We'll need to store some metadata
> about these time series collections, such as which field of the document
> contains the timestamp to route on.
> The current {{/aliases.json}} is a Map with a key {{collection}} which is in
> turn a Map of alias name strings to a comma delimited list of the collections.
> _If we change the comma delimited list to be another Map to hold the existing
> list and more stuff, older CloudSolrClient (configured to talk to ZooKeeper)
> will break_. Although if it's configured with an HTTP Solr URL then it would
> not break. There's also some read/write hassle to worry about -- we may need
> to continue to read an aliases.json in the older format.
> Alternatively, we could add a new map entry to aliases.json, say,
> {{collection_metadata}} keyed by alias name?
> Perhaps another very different approach is to attach metadata to the
> configset in use?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
