[ 
https://issues.apache.org/jira/browse/SOLR-11645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254072#comment-16254072
 ] 

Stefan Matheis (steffkes) commented on SOLR-11645:
--------------------------------------------------

Shawn, i don't have a current checkout / environment - skimming over your patch 
as well as https://docs.angularjs.org/error/ngRepeat/dupes makes it look just 
fine!

bq. I noticed in the javascript code that the command line arguments are sorted 
before they are displayed. Is that something we really want to do? Shouldn't 
they appear in actual order?

I can't say for sure when this landed - i can see both sides of it: having it 
sorted makes it easier to recognize a duplicate (which as far as i know is only 
a technically, java doesn't care about does it?) while having it in the actual 
order probably helps when people are trying to group them in a sorting way 
(relevant things together, or global/local/tenant-based properties).

include this change in this ticket and we'll see where it goes - i'd probably 
bet that most people won't even notice it.

> When there are duplicate java commandline arguments, the Solr UI dashboard 
> doesn't show Args at all
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-11645
>                 URL: https://issues.apache.org/jira/browse/SOLR-11645
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Admin UI
>    Affects Versions: 7.1
>            Reporter: Shawn Heisey
>            Priority: Minor
>         Attachments: SOLR-11645.patch, SOLR-11645.patch
>
>
> A user couldn't get the "Args" to display in the admin UI.
> Ultimately it was determined that they had duplicate arguments on their 
> commandline, and this was resulting in an error in the browser:
> {code}
> Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use
> 'track by' expression to specify unique keys. Repeater: arg in
> commandLineArgs, Duplicate key: string:-XX:+UseGCLogFileRotation, Duplicate
> value: -XX:+UseGCLogFileRotation
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to