[
https://issues.apache.org/jira/browse/SOLR-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265036#comment-16265036
]
Andrzej Bialecki commented on SOLR-11202:
------------------------------------------
A few minor issues:
* {{AutoScalingConfig}} constructor should wrap the provided properties in an
unmodifiableMap.
* {{AutoScalingConfig.withProperties}} is missing javadoc.
* the new {{AutoScalingParams}} use dot-separated names, whereas all other
autoscaling parameters use camel case. Since the latter are already
user-visible in the public releases I think that all of them should use camel
case.
* I think that {{AutoScalingHandlerTest.testSetProperties}} should assert the
impact of changing properties on {{ScheduledTriggers}}, in particular that the
existing triggers are properly canceled & re-scheduled.
> Implement a set-property command for AutoScaling API
> ----------------------------------------------------
>
> Key: SOLR-11202
> URL: https://issues.apache.org/jira/browse/SOLR-11202
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling, SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 7.2, master (8.0)
>
> Attachments: SOLR-11202.patch
>
>
> The Autoscaling API should support a {{set-property}} command so that
> properties specific to autoscaling can be set/unset. Examples of such
> properties are:
> # The scheduled delay between trigger invocations (currently defaults to 1s)
> # Min time between actions (currently defaults to 5s)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
