[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051665#comment-13051665
]
Simon Willnauer commented on LUCENE-2793:
-----------------------------------------
hey varun thanks for the new patch, some comments:
* the nocommit in IW you should maybe add a second ctor to MergeInfo that takes
arguments and then use something like this in IW: final IOContext context = new
IOContext(new MergeInfo(info.docCount, info.sizeInBytes(true), true, false));
* It seems kind of odd to always prefix MergeInfo with OneMerge so maybe move
it into its own file
* regarding the read buffer problem, can you simply use
BufferedIndexInput.BUFFER_SIZE to initialize it and put a TODO / nocommit on top
* You should look into contrib/misc there are some compile errors in
AppendingCodec as well as in solr land.
* I think in Directory the openInput method should be abstract: public
abstract IndexInput openInput(String name, IOContext context) throws
IOException; and FSDirectory should not specify this method at all. Currently
your code would produce a stack overflow since it calls itself.
If I fix the nocommits in your patch test-core passes without problems. Looking
good man we are getting closer!
Simon
> Directory createOutput and openInput should take an IOContext
> -------------------------------------------------------------
>
> Key: LUCENE-2793
> URL: https://issues.apache.org/jira/browse/LUCENE-2793
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/store
> Reporter: Michael McCandless
> Assignee: Varun Thacker
> Labels: gsoc2011, lucene-gsoc-11, mentor
> Attachments: LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch,
> LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch,
> LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch,
> LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch
>
>
> Today for merging we pass down a larger readBufferSize than for searching
> because we get better performance.
> I think we should generalize this to a class (IOContext), which would hold
> the buffer size, but then could hold other flags like DIRECT (bypass OS's
> buffer cache), SEQUENTIAL, etc.
> Then, we can make the DirectIOLinuxDirectory fully usable because we would
> only use DIRECT/SEQUENTIAL during merging.
> This will require fixing how IW pools readers, so that a reader opened for
> merging is not then used for searching, and vice/versa. Really, it's only
> all the open file handles that need to be different -- we could in theory
> share del docs, norms, etc, if that were somehow possible.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
