[
https://issues.apache.org/jira/browse/SOLR-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277071#comment-16277071
]
Cassandra Targett edited comment on SOLR-11715 at 12/4/17 4:55 PM:
-------------------------------------------------------------------
I think you have it backwards in trying to fix it - the text *not* in
{{\[source]}} blocks will get rendered as bold; the point of the source block
is to skip doing that conversion.
There are problematic examples that are missing the query string {{\*:*}}, but
they aren't the examples you've modified in this patch.
In your patch, the example you've changed to fix missing {{\*:*}}, actually
currently renders properly if you look at it online at
https://lucene.apache.org/solr/guide/7_1/spatial-search.html#jts-and-polygons-flat.
Removing the {{\[source]}} block definition will make it start to fail.
An example in another section online at
https://lucene.apache.org/solr/guide/7_1/spatial-search.html#use-as-a-sub-query-to-expand-search-results
is missing {{\*:\*}} and is *not* in a {{\[source]}} block - see also line
#170 of {{spatial-search.adoc}} on master.
The solution is really to *add* the {{\[source,text]}} block definition instead
of removing it.
was (Author: ctargett):
I think you have it backwards in trying to fix it - the text *not* in
{{\[source]}} blocks will get rendered as bold; the point of the source block
is to skip doing that conversion.
There are problematic examples that are missing the query string {{\*:*}}, but
they aren't the examples you've modified in this patch.
In your patch, the example you've changed to fix missing {{\*:*}}, actually
currently renders properly if you look at it online at
https://lucene.apache.org/solr/guide/7_1/spatial-search.html#jts-and-polygons-flat.
Removing the {{\[source]}} block definition will make it start to fail.
An example in another section online at
https://lucene.apache.org/solr/guide/7_1/spatial-search.html#use-as-a-sub-query-to-expand-search-results
is missing {{\*:*}} and is *not* in a {{\[source]}} block - see also line #170
of {{spatial-search.adoc}} on master.
The solution is really to *add* the {{\[source,text]}} block definition instead
of removing it.
> Spatial Search ref-guide fixes
> ------------------------------
>
> Key: SOLR-11715
> URL: https://issues.apache.org/jira/browse/SOLR-11715
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Attachments: SOLR-11715.patch, SOLR-11715.patch
>
>
> Was doing a demo of spatial search and ran into the following problems:
> # Some blocks of code were not formatted properly, hence losing the {{*:*}}
> parameters. Example:
> https://lucene.apache.org/solr/guide/6_6/spatial-search.html#SpatialSearch-bbox
> # The query mentioned for geodist section didn't actually return the scores.
> Need to add an fl parameter there.
> https://lucene.apache.org/solr/guide/6_6/spatial-search.html#SpatialSearch-geodist
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
