[ https://issues.apache.org/jira/browse/SOLR-11412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277355#comment-16277355 ]
Cassandra Targett commented on SOLR-11412: ------------------------------------------ * {{cdcr-api.adoc}} ** I made all the recommended changes you suggested here. * CDCR Architecture Page: bq. "The data changes can be replicated in near real-time (with a small delay) or could be scheduled to be sent at longer intervals to the Target data center" : "The data changes can be replicated at a configurable amount of time" Should Source and Target should start with a capital letter? It was like that before so isn't really related to the new content. I would normally remove the capitalization, but Erick wrote/contributed the page, and it's not so egregious that I thought it had to be changed. I think an argument can be made that in _this_ case, the capitalization works as shorthand for the two clusters. bq. "Since this is a full copy of the entire index, network bandwidth should be considered." : What value does this line add to the user? That he/she should be aware that an entire index is going over the wire and they shouldn't expect it to be done in nanoseconds. The rest of your comments for this page are judgement calls, again mostly not-related to the patch. If you want to make the changes at a later time, go ahead, I can't figure out what does & doesn't add value at the same level that you can. * CDCR Configuration : bq. "<!-- optional -->" : We recommend everyone to disable buffering. Let's remove this comment I did this. bq. "Sync the index directories from the Source collection to Target collection across to the corresponding shard nodes. rsync works well for this" till the end of the section : Seems like a lot of info or notes which are already known? Known by who? bq. "ZooKeeper Settings" 800 is a typo? We say we want to set 200 but use It was already there, I'll assume you know it should be set to 800 in the comment. > Documentation changes for SOLR-11003: Bi-directional CDCR support > ----------------------------------------------------------------- > > Key: SOLR-11412 > URL: https://issues.apache.org/jira/browse/SOLR-11412 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: CDCR, documentation > Reporter: Amrit Sarkar > Assignee: Varun Thacker > Attachments: CDCR_bidir.png, SOLR-11412-split.patch, > SOLR-11412.patch, SOLR-11412.patch, SOLR-11412.patch, SOLR-11412.patch, > SOLR-11412.patch > > > Since SOLR-11003: Bi-directional CDCR scenario support, is reaching its > conclusion. The relevant changes in documentation needs to be done. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org