[ https://issues.apache.org/jira/browse/LUCENE-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277651#comment-16277651 ]
Adrien Grand commented on LUCENE-8015: -------------------------------------- I don't think we can fix this with a nextUp/nextDown? One way we could fix it for sure would be by implementing the basic model and the after effect in a single method. For instance {{(A + B * tfn) * (C / (tfn + 1))}} could be rewritten as {{(A - B + B * (1 + tfn))) * C / (tfn + 1) = (A - B) * C / (tfn + 1) + B * C}}. Since there is only one occurrence of tfn in the latter, it would be guaranteed to be non-decreasing when tfn increases. Fixing it in the general case looks challenging however? Maybe one reasonable way to avoid this issue would be to bound the values that tfn may take? This isn't nice but it wouldn't affect the general case, only when freq, avgdl, or some other stats have extreme values? > TestBasicModelIne.testRandomScoring failure > ------------------------------------------- > > Key: LUCENE-8015 > URL: https://issues.apache.org/jira/browse/LUCENE-8015 > Project: Lucene - Core > Issue Type: Task > Reporter: Adrien Grand > Attachments: LUCENE-8015_test_fangs.patch > > > reproduce with: ant test -Dtestcase=TestBasicModelIne > -Dtests.method=testRandomScoring -Dtests.seed=86E85958B1183E93 > -Dtests.slow=true -Dtests.locale=vi-VN -Dtests.timezone=Pacific/Tongatapu > -Dtests.asserts=true -Dtests.file.encoding=UTF8 -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org