[
https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052137#comment-13052137
]
Simon Willnauer commented on LUCENE-3219:
-----------------------------------------
chris, patch looks good...
some minor comments:
* I wonder if a parser could hold a Type so we could get rid of the if (parser
instanceof FieldCache.$Parser) ?
* in SearchWithSortTask I wonder if you could simply call
Type.valueOf(typeString.toUpperCase()); - the less code the better :)
overall looks good
simon
> Change SortField types to an Enum
> ---------------------------------
>
> Key: LUCENE-3219
> URL: https://issues.apache.org/jira/browse/LUCENE-3219
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/search
> Reporter: Chris Male
> Priority: Minor
> Attachments: LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch
>
>
> When updating my SOLR-2533 patch, one issue was that the int value I had
> given my new type had been used by another change in the mean time. Since we
> don't use these fields in a bitset kind of way, we can convert them to an
> enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
