[
https://issues.apache.org/jira/browse/SOLR-11701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293984#comment-16293984
]
Erick Erickson commented on SOLR-11701:
---------------------------------------
OK, I see what's happening here, but not quite sure why or what the proper fix
would be.
There is a lot more data being dumped out as a result of this patch, see below,
#######WITHOUT THIS PULL and #####WITH THIS PULL. That results in the framework
failing the test because it's too verbose (see ######ERROR).
This test illustrates how this fails, but be aware that if you just run that
test it succeeds (in IntelliJ), you have to run the whole suite.
*ImplicitSnitchTest.testGetTags_with_correct_ipv6_format_ip_returns_nothing()*
Doing what the error says and adding @TestRuleLimitSysouts.Limit(bytes=20000)
causes the test to succeed. I took a quick look at the size of the output file
from a test run and there's about a 7K difference with or without this patch
(and bumping the limit). Is that sufficient?
*#########ERROR*
java.lang.AssertionError: The test or suite printed 9268 bytes to stdout and
stderr, even though the limit was set to 8192 bytes. Increase the limit with
@Limit, ignore it completely with @SuppressSysoutChecks or run with
-Dtests.verbose=true
at __randomizedtesting.SeedInfo.seed([75A0F6DC6F8B91D6]:0)
at
org.apache.lucene.util.TestRuleLimitSysouts.afterIfSuccessful(TestRuleLimitSysouts.java:211)
at
com.carrotsearch.randomizedtesting.rules.TestRuleAdapter$1.afterIfSuccessful(TestRuleAdapter.java:36)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:37)
*#########WITHOUT THIS PULL*
Connected to the target VM, address: '127.0.0.1:51314', transport: 'socket'
0 WARN
(TEST-ImplicitSnitchTest.testGetTags_with_correct_ipv6_format_ip_returns_nothing-seed#[F055DBD86566DD29])
[ ] o.a.s.c.c.r.ImplicitSnitch Failed to get IP address from host [[0],
with exception [java.net.UnknownHostException: [0: invalid IPv6 address]
4 WARN
(TEST-ImplicitSnitchTest.testGetTags_with_correct_ipv6_format_ip_returns_nothing-seed#[F055DBD86566DD29])
[ ] o.a.s.c.c.r.ImplicitSnitch Failed to match host IP address from node
URL [[0:0:0:0:0:0:0:1]:8983_solr] using regex [(?:https?://)?([^:]+):(\d+)]
Disconnected from the target VM, address: '127.0.0.1:51314', transport: 'socket'
*#########WITH THIS PULL (abbreviated)*
objc[44364]: Class JavaLaunchHelper is implemented in both
/Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/bin/java
(0x1015234c0) and
/Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre/lib/libinstrument.dylib
(0x1015af4e0). One of the two will be used. Which one is undefined.
1 WARN
(TEST-ImplicitSnitchTest.testGetTags_with_correct_ipv6_format_ip_returns_nothing-seed#[75A0F6DC6F8B91D6])
[ ] o.a.s.c.c.r.ImplicitSnitch Failed to get IP address from host [[0],
with exception [{}]
java.net.UnknownHostException: [0: invalid IPv6 address
at java.net.InetAddress.getAllByName(InetAddress.java:1146)
at java.net.InetAddress.getAllByName(InetAddress.java:1126)
at java.net.InetAddress.getByName(InetAddress.java:1076)
at
org.apache.solr.common.cloud.rule.ImplicitSnitch.getHostIp(ImplicitSnitch.java:182)
at
org.apache.solr.common.cloud.rule.ImplicitSnitch.getIpFragments(ImplicitSnitch.java:169)
at
org.apache.solr.common.cloud.rule.ImplicitSnitch.addIpTags(ImplicitSnitch.java:145)
at
org.apache.solr.common.cloud.rule.ImplicitSnitch.getTags(ImplicitSnitch.java:73)
at
org.apache.solr.cloud.rule.ImplicitSnitchTest.testGetTags_with_correct_ipv6_format_ip_returns_nothing(ImplicitSnitchTest.java:117)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1737)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:934)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:970)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:984)
at
org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
at
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at
org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
at
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
> Upgrade to Tika 1.17 when available
> -----------------------------------
>
> Key: SOLR-11701
> URL: https://issues.apache.org/jira/browse/SOLR-11701
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Tim Allison
> Assignee: Erick Erickson
> Attachments: SOLR-11701.patch
>
>
> Kicking off release process for Tika 1.17 in the next few days. Please let
> us know if you have any requests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
