[ https://issues.apache.org/jira/browse/SOLR-11801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306370#comment-16306370 ]
David Smiley commented on SOLR-11801: ------------------------------------- Looks fine to me Christine. Some nit picks... * Could CustomHighlightComponent be a static inner class of the test that uses it? * IMO the javadocs on these methods could lose the common leading part "Expert: sub-class and override this method to return highlighting information ..." to just get to the point, or lose it altogether -- some future Solr hacker will probably look at the test to truly get the gist. Protected methods imply you can subclass and override them. It's a matter of taste I know; I don't like repetition or superfluous things. This is up to you. > support customisation of the "highlighting" query response element > ------------------------------------------------------------------ > > Key: SOLR-11801 > URL: https://issues.apache.org/jira/browse/SOLR-11801 > Project: Solr > Issue Type: New Feature > Components: highlighter > Reporter: Christine Poerschke > Assignee: Christine Poerschke > Priority: Minor > Attachments: SOLR-11801.patch, SOLR-11801.patch, SOLR-11801.patch > > > The objective and use case behind the proposed changes is to be able to > receive not the out-of-the-box highlighting map > {code} > { > ... > "highlighting" : { > "MA147LL/A" : { > "manu" : [ > "<em>Apple</em> Computer Inc." > ] > } > } > } > {code} > as illustrated in > https://lucene.apache.org/solr/guide/7_2/highlighting.html#highlighting-in-the-query-response > but to be able to alternatively name and customise the highlighting element > of the query response to (for example) be like this > {code} > { > ... > "custom_highlighting" : [ > { > "id" : "MA147LL/A", > "snippets" : { > "manu" : [ > "<em>Apple</em> Computer Inc." > ] > } > } > ] > } > {code} > where the highlighting element itself is a list and where the keys of each > list element are 'knowable' in advance i.e. they are not 'unknowable' > document ids. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org