[
https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313083#comment-16313083
]
Michael McCandless commented on LUCENE-8113:
--------------------------------------------
I like the new name {{TermStates}}!
Can we change the exception message from:
{noformat}
throw new IllegalStateException("Cannot call docFreq() on lazily
constructed TermStates");
{noformat}
to:
{noformat}
throw new IllegalStateException("Cannot call docFreq() when
needsStats=false");
{noformat}
or so?
Also can you add { } around single-statement if bodies? This is our code
style, and leaving off the { } adds risk to future refactoring. Thanks ;)
> Allow terms dictionary lookups to be lazy when scores are not needed
> --------------------------------------------------------------------
>
> Key: LUCENE-8113
> URL: https://issues.apache.org/jira/browse/LUCENE-8113
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Attachments: LUCENE-8113-rename.patch, LUCENE-8113.patch,
> LUCENE-8113.patch, LUCENE-8113.patch
>
>
> LUCENE-7311 made it possible to avoid loading TermStates in cached
> TermQueries. It would be useful to extend this to other queries that use the
> terms dictionary.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
