[ 
https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313328#comment-16313328
 ] 

Alan Woodward commented on LUCENE-8099:
---------------------------------------

What pushed me over the line on the static methods was the realisation that my 
suggested replacement for BoostingQuery didn't do what I thought it was doing, 
although Hoss's -1 helped :) . And I think I also misread your earlier comment 
about static methods, thinking that you meant them for creating value sources, 
rather than as query replacements.

There isn't an issue with equality comparisons here, because the static methods 
use concrete classes with .equals() and .hashCode() implemented on them for 
their sources.  They should have tests for this though, will add them in.

> Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
> ----------------------------------------------------------
>
>                 Key: LUCENE-8099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8099
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: 7.3
>
>         Attachments: LUCENE-8099-2.patch, LUCENE-8099.patch, LUCENE-8099.patch
>
>
> After LUCENE-7998, these three queries can all be replaced by a 
> FunctionScoreQuery.  Using lucene-expressions makes them much easier to use 
> as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to