[ https://issues.apache.org/jira/browse/SOLR-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314192#comment-16314192 ]
Anshum Gupta commented on SOLR-11739: ------------------------------------- Thanks for taking this up [~tomasflobbe]! This looks good and not super invasive. Here's some feedback: * CollectionsHandler.java ** We should add back the check in old places instead of leaving that as a TODO ** L296: It would be good to log the reason for the failure to offer the request to the OverseerCollectionQueue * Are the log4j.properties changes intentional ? * SizeLimitedDistributedMap.OnChildDeleteObserver interface doesn’t need the keyword static also can you add some javadoc there? * As I understand, you would also want to override clear() and call onDeleteObserver.onChildDelete in those cases too. * Javadocs for claim/clearAsyncId. It’d be good to mention that it returns false when it tries to clear an ID that doesn’t exist any more. > Solr can accept duplicated async IDs > ------------------------------------ > > Key: SOLR-11739 > URL: https://issues.apache.org/jira/browse/SOLR-11739 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Tomás Fernández Löbbe > Assignee: Tomás Fernández Löbbe > Priority: Minor > Attachments: SOLR-11739.patch, SOLR-11739.patch > > > Solr is supposed to reject duplicated async IDs, however, if the repeated IDs > are sent fast enough, a race condition in Solr will let the repeated IDs > through. The duplicated task is ran and and then silently fails to report as > completed because the same async ID is already in the completed map. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org